[PATCH, gimple] Rename gimple_copy_call_skip_args to gimple_call_copy_skip_args
Martin Jambor
mjambor@suse.cz
Tue Sep 23 11:55:00 GMT 2008
Hi,
I believe gimple_copy_call_skip_args should be called
gimple_call_copy_skip_args because all GIMPLE_CALL only accessors
should have the prefix gimple_call_ and this is certainly one of them.
This also has implications for the gcc internals documentation because
the function should be listed as a GIMPLE_CALL accessor and not a
common one.
The patch below addresses both these issues. I have bootstrapped and
tested it on x86_64-suse-linux revision 140555, and i486-linux-gnu
revision 140544 on which I also checked the documentation changes with
make pdf.
OK for trunk?
Thanks,
Martin
2008-09-23 Martin Jambor <mjambor@suse.cz>
* doc/gimple.texi (gimple_copy_call_skip_args): Changed to
gimple_call_copy_skip_args and moved to the gimple_call section.
* gimple.c (gimple_copy_call_skip_args): Renamed to
gimple_call_copy_skip_args. Changed al users.
Index: iinln/gcc/doc/gimple.texi
===================================================================
--- iinln.orig/gcc/doc/gimple.texi
+++ iinln/gcc/doc/gimple.texi
@@ -875,11 +875,6 @@ Update statement @code{S} if it has been
Return a deep copy of statement @code{STMT}.
@end deftypefn
-@deftypefn {GIMPLE function} gimple gimple_copy_call_skip_args (gimple stmt, bitmap args_to_skip)
-Build a @code{GIMPLE_CALL} identical to @code{STMT} but skipping the arguments
-in the positions marked by the set @code{ARGS_TO_SKIP}.
-@end deftypefn
-
@node Tuple specific accessors
@section Tuple specific accessors
@cindex Tuple specific accessors
@@ -1261,6 +1256,11 @@ Return true if @code{GIMPLE_CALL} @code{
Return true if @code{S} is a noreturn call.
@end deftypefn
+@deftypefn {GIMPLE function} gimple gimple_call_copy_skip_args (gimple stmt, bitmap args_to_skip)
+Build a @code{GIMPLE_CALL} identical to @code{STMT} but skipping the arguments
+in the positions marked by the set @code{ARGS_TO_SKIP}.
+@end deftypefn
+
@node @code{GIMPLE_CATCH}
@subsection @code{GIMPLE_CATCH}
Index: iinln/gcc/gimple.c
===================================================================
--- iinln.orig/gcc/gimple.c
+++ iinln/gcc/gimple.c
@@ -3192,7 +3192,7 @@ canonicalize_cond_expr_cond (tree t)
the positions marked by the set ARGS_TO_SKIP. */
gimple
-gimple_copy_call_skip_args (gimple stmt, bitmap args_to_skip)
+gimple_call_copy_skip_args (gimple stmt, bitmap args_to_skip)
{
int i;
tree fn = gimple_call_fn (stmt);
Index: iinln/gcc/gimple.h
===================================================================
--- iinln.orig/gcc/gimple.h
+++ iinln/gcc/gimple.h
@@ -4479,7 +4479,7 @@ basic_block gsi_insert_on_edge_immediate
basic_block gsi_insert_seq_on_edge_immediate (edge, gimple_seq);
void gsi_commit_one_edge_insert (edge, basic_block *);
void gsi_commit_edge_inserts (void);
-gimple gimple_copy_call_skip_args (gimple, bitmap);
+gimple gimple_call_copy_skip_args (gimple, bitmap);
/* Convenience routines to walk all statements of a gimple function.
Index: iinln/gcc/ipa-cp.c
===================================================================
--- iinln.orig/gcc/ipa-cp.c
+++ iinln/gcc/ipa-cp.c
@@ -967,7 +967,7 @@ ipcp_update_callgraph (void)
current_function_decl = cs->caller->decl;
push_cfun (DECL_STRUCT_FUNCTION (cs->caller->decl));
- new_stmt = gimple_copy_call_skip_args (cs->call_stmt,
+ new_stmt = gimple_call_copy_skip_args (cs->call_stmt,
args_to_skip);
gsi = gsi_for_stmt (cs->call_stmt);
gsi_replace (&gsi, new_stmt, true);
More information about the Gcc-patches
mailing list