RFC: PR c/36892: Support __attribute__((deprecated("text string")))
H.J. Lu
hjl.tools@gmail.com
Wed Sep 17 17:55:00 GMT 2008
On Wed, Sep 17, 2008 at 9:32 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Sep 17, 2008 at 8:53 AM, Ian Lance Taylor <iant@google.com> wrote:
>> "H.J. Lu" <hongjiu.lu@intel.com> writes:
>>
>>> This patch adds an optional string for deprecated attribute. I got
>>>
>>> [hjl@gnu-6 770]$ cat y.c
>>> __attribute__ ((deprecated("is replaced by \"new_bar\""))) int bar ();
>>
>> I like the idea but this is not appropriate for stage 3. Can you hold
>> the patch until we go back to stage 1?
>>
>
> Sure. My patch is incomplete and I am looking for feedbacks. Given
>
> what should happen for each case when we replace __attribute__ ((deprecated))
> with __attribute__((deprecated("text string")))?
>
>
Here are the proposed warnings:
[hjl@gnu-6 gcc]$ cat /tmp/deprecated-6.C
/* Test __attribute__ ((deprecated("message"))) */
/* { dg-do compile } */
/* { dg-options "-Wdeprecated-declarations -fmessage-length=0" } */
typedef int INT1 __attribute__((deprecated("Please avoid INT1")));
typedef INT1 INT2 __attribute__ ((__deprecated__("Please avoid INT2")));
typedef INT1 INT1a; /* { dg-warning "'INT1' is deprecated" "" } */
typedef INT1 INT1b __attribute__ ((deprecated("Please avoid INT1b")));
INT1 should_be_unavailable; /* { dg-warning "'INT1' is deprecated" "" } */
INT1a should_not_be_deprecated;
INT1 f1(void) __attribute__ ((deprecated("Please avoid f1")));
INT1 f2(void) { return 0; } /* { dg-warning "'INT1' is deprecated" "" } */
INT2 f3(void) __attribute__ ((__deprecated__("Please avoid f3")));
INT2 f4(void) { return 0; } /* { dg-warning "'INT2' is deprecated" "" } */
int f5(INT2 x); /* { dg-warning "'INT2' is deprecated" "" } */
int f6(INT2 x) __attribute__ ((__deprecated__("Please avoid f6")));
typedef enum Color {red, green, blue} Color
__attribute__((deprecated("Please avoid INT1")));
int g1;
int g2 __attribute__ ((deprecated("Please avoid g2")));
int g3 __attribute__ ((__deprecated__("Please avoid g3")));
Color k; /* { dg-warning "'Color' is deprecated" "" } */
typedef struct {
int field1;
int field2 __attribute__ ((deprecated("Please avoid field2")));
int field3;
int field4 __attribute__ ((__deprecated__("Please avoid field4")));
union {
int field5;
int field6 __attribute__ ((deprecated("Please avoid field6")));
} u1;
int field7:1;
int field8:1 __attribute__ ((deprecated("Please avoid field8")));
union {
int field9;
int field10;
} u2 __attribute__ ((deprecated("Please avoid u2")));
} S1;
int func1()
{
INT1 w; /* { dg-warning "'INT1' is deprecated" "" } */
int x __attribute__ ((deprecated("Please avoid x")));
int y __attribute__ ((__deprecated__("Please avoid y")));
int z;
int (*pf)() = f1; /* { dg-warning "'INT1 f1\\(\\)' is deprecated" "" } */
z = w + x + y + g1 + g2 + g3; /* { dg-warning "'x' is deprecated" "" } */
/* { dg-warning "'y' is deprecated" "y" { target *-*-* } 55 } */
/* { dg-warning "'g2' is deprecated" "g2" { target *-*-* } 55 } */
/* { dg-warning "'g3' is deprecated" "g3" { target *-*-* } 55 } */
return f1(); /* { dg-warning "'INT1 f1\\(\\)' is deprecated" "f1" } */
}
int func2(S1 *p)
{
S1 lp;
if (p->field1)
return p->field2; /* { dg-warning "'S1::field2' is deprecated" "" } */
else if (lp.field4) /* { dg-warning "'S1::field4' is deprecated" "" } */
return p->field3;
p->u1.field5 = g1 + p->field7;
p->u2.field9; /* { dg-warning "'S1::u2' is deprecated" "" } */
return p->u1.field6 + p->field8; /* { dg-warning "'S1::<anonymous
union>::field6' is deprecated" "" } */
/* { dg-warning "'S1::field8' is deprecated" "field8" { target
*-*-* } 73 } */
}
struct SS1 {
int x;
INT1 y; /* { dg-warning "'INT1' is deprecated" "" } */
} __attribute__ ((deprecated("Please avoid SS1")));
struct SS1 *p1; /* { dg-warning "'SS1' is deprecated" "" } */
struct __attribute__ ((__deprecated__("Please avoid SS2"))) SS2 {
int x;
INT1 y; /* { dg-warning "'INT1' is deprecated" "" } */
};
struct SS2 *p2; /* { dg-warning "'SS2' is deprecated" "" } */
#ifdef __cplusplus
class T {
public:
void member1(int) __attribute__ ((deprecated("Please avoid member1")));
void member2(INT1) __attribute__ ((__deprecated__("Please avoid
member2"))); /* { dg-warning "'INT1' is deprecated" "" } */
int member3(T *);
int x;
} __attribute__ ((deprecated("Please avoid INT1")));
T *p3; // { dg-warning "'T' is deprecated" }
inline void T::member1(int) {}
int T::member3(T *p) // { dg-warning "'T' is deprecated" }
{
p->member1(1); /* { dg-warning "'void T::member1\\(int\\)' is
deprecated" "" } */
(*p).member1(2); /* { dg-warning "'void T::member1\\(int\\)' is
deprecated" "" } */
p->member2(1); /* { dg-warning "'void T::member2\\(INT1\\)' is
deprecated" "" } */
(*p).member2(2); /* { dg-warning "'void T::member2\\(INT1\\)' is
deprecated" "" } */
p->member3(p);
(*p).member3(p);
return f1(); /* { dg-warning "'INT1 f1\\(\\)' is deprecated" "" } */
}
#endif
[hjl@gnu-6 gcc]$ ./xgcc -B./ -S -Wdeprecated-declarations /tmp/deprecated-6.C
/tmp/deprecated-6.C:8: warning: 'INT1' is deprecated (declared at
/tmp/deprecated-6.C:5): Please avoid INT1
/tmp/deprecated-6.C:11: warning: 'INT1' is deprecated (declared at
/tmp/deprecated-6.C:5): Please avoid INT1
/tmp/deprecated-6.C:15: warning: 'INT1' is deprecated (declared at
/tmp/deprecated-6.C:5): Please avoid INT1
/tmp/deprecated-6.C:18: warning: 'INT2' is deprecated (declared at
/tmp/deprecated-6.C:6): Please avoid INT2
/tmp/deprecated-6.C:19: warning: 'INT2' is deprecated
/tmp/deprecated-6.C:27: warning: 'Color' is deprecated (declared at
/tmp/deprecated-6.C:22): Please avoid INT1
/tmp/deprecated-6.C: In function 'int func1()':
/tmp/deprecated-6.C:48: warning: 'INT1' is deprecated (declared at
/tmp/deprecated-6.C:5): Please avoid INT1
/tmp/deprecated-6.C:52: warning: 'INT1 f1()' is deprecated (declared
at /tmp/deprecated-6.C:14): Please avoid f1
/tmp/deprecated-6.C:54: warning: 'x' is deprecated (declared at
/tmp/deprecated-6.C:49): Please avoid x
/tmp/deprecated-6.C:54: warning: 'y' is deprecated (declared at
/tmp/deprecated-6.C:50): Please avoid y
/tmp/deprecated-6.C:54: warning: 'g2' is deprecated (declared at
/tmp/deprecated-6.C:25): Please avoid g2
/tmp/deprecated-6.C:54: warning: 'g3' is deprecated (declared at
/tmp/deprecated-6.C:26): Please avoid g3
/tmp/deprecated-6.C:58: warning: 'INT1 f1()' is deprecated (declared
at /tmp/deprecated-6.C:14): Please avoid f1
/tmp/deprecated-6.C:58: warning: 'INT1 f1()' is deprecated (declared
at /tmp/deprecated-6.C:14): Please avoid f1
/tmp/deprecated-6.C: In function 'int func2(S1*)':
/tmp/deprecated-6.C:66: warning: 'S1::field2' is deprecated (declared
at /tmp/deprecated-6.C:31): Please avoid field2
/tmp/deprecated-6.C:66: warning: 'S1::field2' is deprecated (declared
at /tmp/deprecated-6.C:31): Please avoid field2
/tmp/deprecated-6.C:67: warning: 'S1::field4' is deprecated (declared
at /tmp/deprecated-6.C:33): Please avoid field4
/tmp/deprecated-6.C:67: warning: 'S1::field4' is deprecated (declared
at /tmp/deprecated-6.C:33): Please avoid field4
/tmp/deprecated-6.C:71: warning: 'S1::u2' is deprecated (declared at
/tmp/deprecated-6.C:43): Please avoid u2
/tmp/deprecated-6.C:71: warning: 'S1::u2' is deprecated (declared at
/tmp/deprecated-6.C:43): Please avoid u2
/tmp/deprecated-6.C:72: warning: 'S1::<anonymous union>::field6' is
deprecated (declared at /tmp/deprecated-6.C:36): Please avoid field6
/tmp/deprecated-6.C:72: warning: 'S1::<anonymous union>::field6' is
deprecated (declared at /tmp/deprecated-6.C:36): Please avoid field6
/tmp/deprecated-6.C:72: warning: 'S1::field8' is deprecated (declared
at /tmp/deprecated-6.C:39): Please avoid field8
/tmp/deprecated-6.C:72: warning: 'S1::field8' is deprecated (declared
at /tmp/deprecated-6.C:39): Please avoid field8
/tmp/deprecated-6.C: At global scope:
/tmp/deprecated-6.C:78: warning: 'INT1' is deprecated (declared at
/tmp/deprecated-6.C:5): Please avoid INT1
/tmp/deprecated-6.C:81: warning: 'SS1' is deprecated (declared at
/tmp/deprecated-6.C:76): Please avoid SS1
/tmp/deprecated-6.C:85: warning: 'INT1' is deprecated (declared at
/tmp/deprecated-6.C:5): Please avoid INT1
/tmp/deprecated-6.C:88: warning: 'SS2' is deprecated (declared at
/tmp/deprecated-6.C:83): Please avoid SS2
/tmp/deprecated-6.C:94: warning: 'INT1' is deprecated
/tmp/deprecated-6.C:99: warning: 'T' is deprecated (declared at
/tmp/deprecated-6.C:91): Please avoid INT1
/tmp/deprecated-6.C:103: warning: 'T' is deprecated (declared at
/tmp/deprecated-6.C:91): Please avoid INT1
/tmp/deprecated-6.C: In member function 'int T::member3(T*)':
/tmp/deprecated-6.C:105: warning: 'void T::member1(int)' is deprecated
(declared at /tmp/deprecated-6.C:101): Please avoid member1
/tmp/deprecated-6.C:106: warning: 'void T::member1(int)' is deprecated
(declared at /tmp/deprecated-6.C:101): Please avoid member1
/tmp/deprecated-6.C:107: warning: 'void T::member2(INT1)' is
deprecated (declared at /tmp/deprecated-6.C:94): Please avoid member2
/tmp/deprecated-6.C:108: warning: 'void T::member2(INT1)' is
deprecated (declared at /tmp/deprecated-6.C:94): Please avoid member2
/tmp/deprecated-6.C:111: warning: 'INT1 f1()' is deprecated (declared
at /tmp/deprecated-6.C:14): Please avoid f1
/tmp/deprecated-6.C:111: warning: 'INT1 f1()' is deprecated (declared
at /tmp/deprecated-6.C:14): Please avoid f1
[hjl@gnu-6 gcc]$
Do they make any senses?
Thanks.
--
H.J.
More information about the Gcc-patches
mailing list