[Patch, fortran] PR37159

Dennis Wassel dennis.wassel@googlemail.com
Mon Sep 8 23:17:00 GMT 2008


2008/8/24 Dennis Wassel <dennis.wassel@googlemail.com>:
> Heej list,
>
> here my first ever attempt at submitting a patch!
> I'll start an overnight bootstrap and regression test on GNU
> x86-32(-virtualbox)-linux and until then -well- look forward to some
> tutoring :-)
>
> Cheers,
> Dennis
>

Ok, here is my reworked patch, this time also posted to gcc-patches.
I have worked on coding style (taking the liberty to adapt some
existing comments in check.c) and replaced the HAVE_GFC_REAL_16 by
gfc_validate_kind() in check.c, as Tobias suggested.

Currently regression-testing on my x86-32-linux. Takes >1h (big >) on
my Virtualbox - is this normal or just virtualisation slowing things
down?
As Thomas Koenig suggested, this should also be tested on a system
which has REAL(16), but I don't have access to one, and using the
compile farm doesn't look trivial enough to just give it a spin -
could someone with such a system do me that favour? Thanks a lot!
Speaking of testing: I still have not come up with a solution to
telling systems with REAL(10) and (16) apart in the testsuite. Further
ideas?

I cannot convince my mailer to attach the f90-file as MIME-type text -
should I use a "rename trick" (i.e. add .txt suffix) or is this fine
with everybody?

And lastly: Is this the proper way to do the Changelog?

gcc/Changelog:
2008-09-09  Dennis Wassel  <dennis.wassel@googlemail.com>
	PR fortran/37159
	* fortran/check.c (gfc_check_random_seed): Check size of PUT array at
compile time.

libgfortran/Changelog:
2008-09-09  Dennis Wassel  <dennis.wassel@googlemail.com>
	PR fortran/37159
	* intrinsics/random.c: Added comment to adapt check.c, should kiss_size change.
	Few cosmetic changes to existing comments.

testsuite/Changelog:
2008-09-09  Dennis Wassel  <dennis.wassel@googlemail.com>
	PR fortran/37159
	* gfortran.dg/random_seed_1.f90: New testcase.

-- Dennis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: random_seed.diff
Type: text/x-diff
Size: 3813 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20080908/1ea8fb2e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: random_seed_1.f90
Type: application/octet-stream
Size: 392 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20080908/1ea8fb2e/attachment.obj>


More information about the Gcc-patches mailing list