[patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build

Kai Tietz Kai.Tietz@onevision.com
Mon Sep 8 10:54:00 GMT 2008


"Joseph S. Myers" <joseph@codesourcery.com> wrote on 05.09.2008 21:56:54:

> On Fri, 5 Sep 2008, Kai Tietz wrote:
> 
> > I missed to refresh my patch file. Sorry for this. I introduced 
prev_value 
> > to prevent the multiple setting of the array elements. If you mean, I 
can 
> > remove this code.
> 
> An initialization hook should be called just once - but it looks like it 

> would be harmless to call this more than once even without the 
prev_value 
> code.  Furthermore, I think you can initialize the variable to 1 rather 
> than needing to check for a -1 value.  Only the -Wno- version has any 
> effect, after all, and the documentation should make that clear (that 
the 
> -Wno- option disables some warnings with -Wformat -pedantic).

Well, I adjusted the patch as you suggested. Is it ok for apply?

Cheers,
Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mingw-ped-warning.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20080908/94201280/attachment.txt>


More information about the Gcc-patches mailing list