RFA: patch to fix IRA performance degradation

Peter Bergner bergner@vnet.ibm.com
Fri Sep 5 05:08:00 GMT 2008


On Thu, 2008-09-04 at 19:40 -0400, Vladimir Makarov wrote:
> The following patch fixes significant performance degradation
> introduced by a recent patch to process allocnos on reverse traverse
> of BB insns.  Originally the patch was created by Richard Sandiford.  I
> just added a comment to ALLOCNO_ORDER_COMPARE.
> 
> It was succefully bootstrapped on x86_64.
> 
> 2008-09-04  Richard Sandiford  <rdsandiford@googlemail.com>
>         Vladimir Makarov  <vmakarov@redhat.com>
> 
>     * ira-int.h (ALLOCNO_ORDER_COMPARE): New.
> 
>     * ira-color.c (allocno_cost_compare_func,
>     bucket_allocno_compare_func, bucket_allocno_compare_func,
>     push_allocnos_to_stack, allocno_priority_compare_func): Use it.
> 
>     * ira-build.c (ira_swap_allocno_copy_ends_if_necessary): Ditto.

As  mentioned in the other thread, let's wait on this patch until we
have determined why this patch helps performance.  It the end this
may be what we apply, but my gut feeling is this is papering over
some real problem.

Peter





More information about the Gcc-patches mailing list