RFA: patch to solve spec2006 degradation reported in 37243

Vladimir Makarov vmakarov@redhat.com
Thu Sep 4 15:39:00 GMT 2008


H.J. Lu wrote:
> On Wed, Sep 03, 2008 at 04:22:20PM -0400, Vladimir Makarov wrote:
>   
>> Jeff Law wrote:
>>     
>>> Vladimir Makarov wrote:
>>>       
>>>> The following patch solves SPEC2006 degradation reported in PR37243.
>>>> The analysis of the problem can be found in
>>>>
>>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37243
>>>>
>>>> The patch was successfully bootstrapped and tested on x86_64.
>>>>
>>>> 2008-08-30  Vladimir Makarov  <vmakarov@redhat.com>
>>>>
>>>>    PR rtl-opt/37243
>>>>
>>>>    * ira-int.h (ira_loop_tree_node): Rename mentioned_allocnos to
>>>>    all_allocnos.
>>>>
>>>>    * ira-color.c (print_loop_title): Use all_allocnos.
>>>>    (color_pass): Ditto.  Don't add border_allocnos.  Check that
>>>>    subloop allocno in the correspdoning bitmap all_allocnos.
>>>>
>>>>    * ira-emit.c (change_loop): Use all_allocnos.
>>>>
>>>>    * ira-build.c (create_loop_tree_nodes, finish_loop_tree_node):
>>>>    Ditto.
>>>>    (ira_create_allocno): Set up all_allocnos bit for the created
>>>>    allocno.
>>>>    (create_cap_allocno): Remove setting mentioned_allocnos.
>>>>    (create_insn_allocnos): Ditto.
>>>>    (remove_unnecessary_allocnos): Use all_allocnos.
>>>>    (check_allocno_creation): Check that allocnos are in the
>>>>    corresponding bitmap all_allocnos.
>>>>   
>>>>         
>>> OK.  Please install if you haven't done so already.
>>>       
>> Thanks.  Done.
>>     
>
> Here is the testcase for this bug. It failed at -O2 before the
> fix was checked in.  OK for trunk?
>
>
> 2008-09-03  H.J. Lu  <hongjiu.lu@intel.com>
>
> 	PR rtl-optimization/37243
> 	* gfortran.dg/pr37243.f: New.
>
>
>   
Thanks, H.J.  It looks ok to me to commit to the trunk.  That was a 
really good test for IRA.  I should have added it the first time.



More information about the Gcc-patches mailing list