[PATCH] target/37283: Fix -fno-unit-at-a-time and ?-fno-toplevel-reorder handling

Ian Lance Taylor iant@google.com
Tue Sep 2 18:53:00 GMT 2008


Janis Johnson <janis187@us.ibm.com> writes:

> On Tue, 2008-09-02 at 08:04 -0700, Ian Lance Taylor wrote:
>> Samuel Tardieu <sam@rfc1149.net> writes:
>> > +      /* We disable toplevel reordering at -O0 to disable transformations that
>> > +	 might be surprising to end users and to get -fno-toplevel-reorder
>> > +	 tested, but we keep section anchors.  */
>> 
>> This comment looks wrong.
>
> The comment was moved, and with -O0 we get no toplevel-reorder and
> section anchors, which the following check disallows when the user
> tries to set those explicitly.

I'm not sure whether you are agreeing with my comment or disagreeing,
but I should clarify: the comment does not describe the code to which
it is attached.

Ian



More information about the Gcc-patches mailing list