[patch] cosmetics for configure* in gcc

Paolo Bonzini bonzini@gnu.org
Tue Sep 2 15:02:00 GMT 2008


>>> I don't think the m4_do call should be quoted.  In the last case this
>>> results in a weird cache variable
>>> (acx_cv_prog_cc_pedantic_m4_do__Wno_long_long__Wno_variadic_macros_____________Wno_overlength_strings_)
>>> because ACX_PROG_CC_WARNING_ALMOST_PEDANTIC does not expand the first
>>> argument when constructing it (which I think is correct).
>> I think the safest option would be m4_quote(m4_do(...)).  Otherwise, the
>> day someone adds -Wno-dnl you might be screwed. :-)
> 
> Good point, although autoconf wouldn't allow the word dnl to appear in
> the output anyway.

Preapproved, in case it wasn't clear.

Paolo



More information about the Gcc-patches mailing list