[Patch/cygming]: Null terminate string returned by i386_pe_strip_name_encoding_full.

[Tom Tromey]

>>>>> "Danny" == Danny Smith <dansmister@gmail.com> writes:

Danny> Reverting my patch and applying  yours does solve the problem with
Danny> section names.
Danny> I'll do a bootstrap to see if creates any new problems.

Thanks.

I bootstrapped and regtested it on x86-64 (compile farm).

Ok?

Tom

gcc/ChangeLog:
2008-10-03  Tom Tromey  <tromey@redhat.com>

	* stringpool.c (ggc_alloc_string): Terminate string.

Index: gcc/stringpool.c
===================================================================
--- gcc/stringpool.c	(revision 139674)
+++ gcc/stringpool.c	(working copy)
@@ -18,9 +18,8 @@
 along with GCC; see the file COPYING3.  If not see
 <http://www.gnu.org/licenses/>.  */
 
-/* String text, identifier text and identifier node allocator.  Strings
-   allocated by ggc_alloc_string are stored in an obstack which is
-   never shrunk.  Identifiers are uniquely stored in a hash table.
+/* String text, identifier text and identifier node allocator.
+   Identifiers are uniquely stored in a hash table.
 
    We use cpplib's hash table implementation.  libiberty's
    hashtab.c is not used because it requires 100% average space
@@ -76,9 +75,7 @@
 
 /* Allocate and return a string constant of length LENGTH, containing
    CONTENTS.  If LENGTH is -1, CONTENTS is assumed to be a
-   nul-terminated string, and the length is calculated using strlen.
-   If the same string constant has been allocated before, that copy is
-   returned this time too.  */
+   nul-terminated string, and the length is calculated using strlen.  */
 
 const char *
 ggc_alloc_string (const char *contents, int length)
@@ -94,7 +91,8 @@
     return digit_string (contents[0] - '0');
 
   result = GGC_NEWVAR (char, length + 1);
-  memcpy (result, contents, length + 1);
+  memcpy (result, contents, length);
+  result[length] = '\0';
   return (const char *) result;
 }