[4.5][PING] New pass to partition single function into multiple sections
Revital1 Eres
ERES@il.ibm.com
Wed Nov 19 14:57:00 GMT 2008
Hello,
> Here are comments for the SPU part.
Thanks for the comments.
I addressed them in the attached patch and added two new
testcases.
I am currently testing named-addr-spaces-branch with the patch
on SPU and x86.
OK for the branch once testing completes?
Revital
(See attached file: patch_partition_19_11.txt)(See attached file:
patch_testsuite_19_11.txt)(See attached file: ChangeLog.txt)
>
> end_critical_section
> The -msafe-dma and -munsafe-dma flags control when the channel
> instructions are a PARALLEL or not. This function assumes -msafe-dma
is
> always true so will not be correct when using -munsafe-dma.
>
> In spu.opt, there is a typo: "overlay manger".
>
> With those changes the SPU part of the patch is OK.
>
> Trevor
>
> * Revital1 Eres <ERES@il.ibm.com> [2008-11-18 00:00]:
> > Hello,
> >
> > > The following patches are currently pending review for 4.5:
> > >
> > > * [PATCH 1/2] New pass to partition single function into multiple
> > sections
> > > http://gcc.gnu.org/ml/gcc-patches/2008-10/msg00784.html
> > > The machine independent parts of this patch were reviewed by Michael
> > > Meissner: http://gcc.gnu.org/ml/gcc-patches/2008-09/msg01370.html
> >
> > One clarification regarding patch 1/2:
> > Besides my request to commit it to named-addr-spaces-branch I would
like>
> > it to be checked into the development branch when the 4.5 tree opens
up.>
> > Thus I highly appreciate it if the relevant maintainers could review
> > it so I could address their comments on time for 4.5. (the SPU part
> > haven't been reviewed yet)
> >
> > Thanks,
> > Revital
> >
> >
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_partition_19_11.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20081119/90d557e0/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_testsuite_19_11.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20081119/90d557e0/attachment-0001.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ChangeLog.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20081119/90d557e0/attachment-0002.txt>
More information about the Gcc-patches
mailing list