[4.5][PING] New pass to partition single function into multiple sections

Trevor_Smigiel@playstation.sony.com Trevor_Smigiel@playstation.sony.com
Tue Nov 18 23:33:00 GMT 2008


Revital,

Here are comments for the SPU part.

end_critical_section
  The -msafe-dma and -munsafe-dma flags control when the channel
  instructions are a PARALLEL or not.  This function assumes -msafe-dma is
  always true so will not be correct when using -munsafe-dma.

In spu.opt, there is a typo: "overlay manger".

With those changes the SPU part of the patch is OK.

Trevor

* Revital1 Eres <ERES@il.ibm.com> [2008-11-18 00:00]:
> Hello,
> 
> > The following patches are currently pending review for 4.5:
> >
> > * [PATCH 1/2] New pass to partition single function into multiple
> sections
> > http://gcc.gnu.org/ml/gcc-patches/2008-10/msg00784.html
> > The machine independent parts of this patch were reviewed by Michael
> > Meissner: http://gcc.gnu.org/ml/gcc-patches/2008-09/msg01370.html
> 
> One clarification regarding patch 1/2:
> Besides my request to commit it to named-addr-spaces-branch I would like>
> it to be checked into the development branch when the 4.5 tree opens up.>
> Thus I highly appreciate it if the relevant maintainers could review
> it so I could address their comments on time for 4.5. (the SPU part
> haven't been reviewed yet)
> 
> Thanks,
> Revital
> 
> 



More information about the Gcc-patches mailing list