[lto] Add test case for ICE after error messages
Janis Johnson
janis187@us.ibm.com
Fri Nov 14 18:38:00 GMT 2008
On Thu, 2008-11-13 at 07:24 -0500, Hans-Peter Nilsson wrote:
> On Thu, 13 Nov 2008, Diego Novillo wrote:
> > On Thu, Nov 13, 2008 at 06:36, Hans-Peter Nilsson <hp@bitrange.com> wrote:
> > > On Sun, 9 Nov 2008, Diego Novillo wrote:
> > >> +++ gcc.dg/lto/20081109_0.c (revision 0)
> > >> @@ -0,0 +1,3 @@
> > >> +/* { dg-do compile } */
> > >> +/* { dg-options "{-w -flto-single}" } */
> > > The curlies look redundant, if not benevolently wrong, a new
> > > style using tcl quotes.
> >
> > They aren't, unfortunately. dg-options is a list of lists. The main
> > loop in lto.exp:lto-execute does 'foreach option $option_list'.
> > Without the braces, "-w -flto-single" would do two compiles, one with
> > -w and one with -flto-single.
>
> Ah, I didn't notice it was so different from other dg-options... Ouch.
>
> > I've been debating whether to make dg-options just a single string, as
> > it's fairly easy to be stung by this.
>
> Or rename it to dg-multi-options or dg-torture-options or
> better, maybe.
>
> Just trying to avoid a multitude of dejagnu styles complicating
> maintenance - or machine translations to something better. ;)
I agree with H-P, please use a different name for your dg-options.
Janis
More information about the Gcc-patches
mailing list