[PATCH] Fix -Wsign-compare ICE with complex type (PR c/35430)

Jakub Jelinek jakub@redhat.com
Tue Nov 4 16:48:00 GMT 2008


On Tue, Nov 04, 2008 at 02:14:27PM +0100, Manuel López-Ibáñez wrote:
> 2008/11/4 Jakub Jelinek <jakub@redhat.com>:
> > The only such place is when BIT_NOT_EXPR is involved, but
> > BIT_NOT_EXPR of a host integer would be folded away and ~cplx_expr
> > is CONJ_EXPR, not BIT_NOT_EXPR.
> [...]
> > Using TYPE_UNSIGNED (base_type)
> > instead of TYPE_UNSIGNED (result_type) is unnecessary, as complex types copy
> > the unsigned flag from the component type.
> 
> Wouldn't be appropriate to include part of this explanation as
> comments in the code?

I don't think so.

	Jakub



More information about the Gcc-patches mailing list