[PATCH] Don't run link or runtime -mcpu=cell tests unless assembler supports cell (PR target/37812)

Janis Johnson janis187@us.ibm.com
Mon Nov 3 17:51:00 GMT 2008


On Mon, 2008-11-03 at 10:48 +0100, Jakub Jelinek wrote:
> Hi!
> 
> Some old versions of gas don't support Cell insns.  I think it is safe to
> assume that people who use -mcpu=cell do it only if their assembler supports
> it (after all, that's what we do for all other insn extensions, until gcc
> has builtin assembler support, gcc shouldn't workaround missing assembler
> support by using .word or .long all the time).  But gcc's testcase should
> run or link with -mcpu=cell only when it is supported.
> 
> The following patch fixes it.  There is no need for altivec_cell_check
> to use lvlx insn everywhere, it is only needed in -mcpu=cell runtime tests.
> The second and third changed file are to only run -mcpu=cell runtime/link tests
> if assembler support is there.
> 
> Tested briefly on powerpc64-linux, additionally changed lvlx to lvl__x in
> altivec_check.h (to get an expected FAIL on altivec-cell-8, to emulate
> missing assembler support for lvlx) and in target-supports.exp (in that case
> altivec-cell-8 was UNSUPPORTED and it didn't matter what altivec_check.h
> contained).
> 
> Ok for trunk?

OK.

Janis



More information about the Gcc-patches mailing list