[PATCH] Fix overzealous folding

Mark Mitchell mark@codesourcery.com
Thu May 29 21:07:00 GMT 2008


Richard Guenther wrote:

> It doesn't make sense.  Like it doesn't make sense to test that it is
> not a BOOLEAN_TYPE.
> But it papers over(?) a problem elsewhere and fixes the wrong-code bug for Ada.

That's what I thought.  And, normally, we avoid patches that paper over 
problems.  So, I would ask that Eric figure out where it goes wrong, and 
then fix the real problem, even if that fix turns out to be "remove use 
of TYPE_{MIN,MAX}_VALUE" throughout?

I'd be OK with a papering-over fix for a release branch if we don't have 
time for a better fix -- but we should be fixing things correctly on 
mainline.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713



More information about the Gcc-patches mailing list