[PATCH] profile feedback: -fprofile-use= and -fprofile-correction, correctness fixes and option semantic changes.

Seongbae Park (박성배, 朴成培) seongbae.park@gmail.com
Wed May 28 23:32:00 GMT 2008


On Wed, May 28, 2008 at 11:15 AM, Seongbae Park (박성배, 朴成培)
<seongbae.park@gmail.com> wrote:
> On Wed, May 28, 2008 at 5:57 AM, Jan Hubicka <jh@suse.cz> wrote:
>>>
>>> ping^3 (or ^4 counting ping on irc :)) for the above patch and:
>>>
>>> http://gcc.gnu.org/ml/gcc-patches/2008-04/msg00112.html
>>
>> This is OK^4.  Thanks for the patience and reminding me!
>>
>> Honza
>>>
>>> Seongbae
>
> Now that I got the approval, synced to the latest, and ran the test again,
> I noticed that the patch as is was causing an extra FAIL
> due to the additional source file in this patch not being ignored.
>
> I've worked around it by a hack. I think the change is obvious
> (although somewhat hideous)
> since it doesn't change the real testcase nor the actual fix.
> So I've committed this as revision 136118.
> The patch as applied is attached.
>
> Seongbae
>
> 2008-05-28  Seongbae Park <seongbae.park@gmail.com>
>
>       * value-prof.c (tree_ic_transform): Print counts.
>       * tree-profile.c (tree_gen_ic_func_profiler):
>       Clear __gcov_indreict_call_callee variable
>       to avoid misattribution of the profile.
>
> 2008-05-28  Seongbae Park <seongbae.park@gmail.com>
>
>        * gcc.dg/tree-prof/ic-misattribution-1.c: New test.
>        * gcc.dg/tree-prof/ic-misattribution-1a.c: New test.
>        * lib/profopt.exp (profopt-get-options): Support dg-additional-sources.
>        (profopt-execute): Handle additional sources.
>

This patch broke bootstrap on targets where gcov_type != long long int.
Applied the following patch as obvious (after consulting global
maintainers on irc) - svn revision 136131.
Sorry about the breakage.

Seongbae

2008-05-28  Seongbae Park  <seongbae.park@gmail.com>

        * value-prof.c (tree_ic_transform): Use HOST_WIDEST_INT_PRINT_DEC
        for printing gcov_type.


More information about the Gcc-patches mailing list