[testsuite, commited] scandump.exp, handle non-existent dump file

Janis Johnson janis187@us.ibm.com
Wed May 21 17:34:00 GMT 2008


On Wed, 2008-05-21 at 10:14 +0200, Richard Guenther wrote:
> On Wed, May 21, 2008 at 1:38 AM, Janis Johnson <janis187@us.ibm.com> wrote:
> > An attempt in a test to scan a dump file that doesn't exist results in
> > an ugly ERROR message in the .sum file.  Handle non-existent dump files
> > and instead report that checks that depend on it are UNRESOLVED.
> > Tested on powerpc64-linux with -m32/-m64, checked in on trunk.
> 
> Shouldn't it instead FAIL?  As in if I have a typo in the dump file name, or as
> if I test for vectorization but there are no loops in the function?

> > +    set output_file "[glob -nocomplain $src.[lindex $args 2]]"
> > +    if { $output_file == "" } {
> > +       fail "$testname: dump file does not exist"
> > +       return
> > +    }

I was wrong about the UNRESOLVED part.  A scandump check is now
reported as a failure when the dump file is missing.  The report
goes from this:

ERROR: gcc.dg/var-expand3.c: error executing dg-final: no files matched glob pattern "var-expand3.c.[0-9][0-9][0-9]r.loop2_unroll"
UNRESOLVED: gcc.dg/var-expand3.c: error executing dg-final: no files matched glob pattern "var-expand3.c.[0-9][0-9][0-9]r.loop2_unroll"

to this:

FAIL: gcc.dg/var-expand3.c scan-rtl-dump loop2_unroll "Expanding Accumulator": dump file does not exist

Janis



More information about the Gcc-patches mailing list