[libgfortran,patch] Wide char part 4, library support

Tobias Burnus burnus@net-b.de
Wed May 14 17:06:00 GMT 2008


FX wrote:
> This patch provides a character(kind=4) version of the functions inh 
> intrinsics/string_intrinsics.c, as well as a few needed definitions in 
> libgfortran.h.
>
> Bootstrapped and regtested on x86_64-linux, OK to commit?
OK.

> Of course, you now wonder why doing the library before the rest of the 
> front-end. Well, it so happens that I actually have done the front-end 
> bits too, so I now almost have a feature-complete widechar gfortran 
> (except I/O, for which I'll need Jerry's or Janne's help), and I could 
> test these intrinsics and they behave fairly well so far. But, the 
> front-end patch still has a few bugs, so I submit this easier and 
> self-contained patch while I fix the last bugs in the front-end.

I'm looking forward for the front-end part.

I was wondering whether one should warn for/reject default kind (= 1) 
literals with non-ascii characters with -pedantic.

Do you plan to enable character kind = 4 support even without I/O 
support? I think one could do so, but until UTF-8 is supported our 
implementation would not be Fortran 2003 conform. (When a wide-char kind 
is available, UTF-8 I/O needs to be supported; if not, it does not need to.)

Tobias

PS: You replied regarding part 3:
> Thanks for the review. I'm not sure I understand your last part, 
> though: do you want me not to add a testcase derived from the PR, or 
> do you want me to (as I proposed)? 
I missed that you proposed to add the test case. My I idea was to add a 
test case, which you did.



More information about the Gcc-patches mailing list