[PATCH] Fix pch failures when opening a header that has been precompiled multiple times (PR pch/13675)

Tom Tromey tromey@redhat.com
Mon Mar 31 19:30:00 GMT 2008


>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:

Jakub> The fix below clears pch (and frees pchname) once the *.gch
Jakub> file is read using cb.read_pch, which means that an include
Jakub> file won't be handled as a PCH file in the second and following
Jakub> #include (which matches the PCH design).

Jakub> This patch also removes unnecessary field from struct _cpp_file
Jakub> (file->pch is true iff file->pchname != NULL) and fixes a
Jakub> double close bug

This looks good to me.

I don't think I can approve the c-pch.c part.

If you want to check in the deletion of the field in libcpp
separately, that would be fine by me.  But, waiting for full approval
is also ok.

Tom



More information about the Gcc-patches mailing list