[PATCH,fortran]: Emit COMMON identifiers in proper debug scope

George Helffrich george@geology.bristol.ac.uk
Fri Mar 21 17:32:00 GMT 2008


On 20 Mar 2008, at 17:15, Jason Merrill wrote:

> It looks like this patch can generate DW_TAG_common_block for 
> languages other than FORTRAN, which seems undesirable.  Specifically, 
> it seems that any use of DECL_VALUE_EXPR could trigger this code, such 
> as anonymous unions in C++.  I notice that you even have C++-specific 
> code in common_check.
>
> Jason
>
>

Thanks for spotting that; easily guarded against with an !if_fortran() 
test at the start of common_check.  With that, the C++-specific code 
can be eliminated, too.

--
George Helffrich



More information about the Gcc-patches mailing list