[PATCH] contrib/patch_tester.sh, 7 of 7

Janis Johnson janis187@us.ibm.com
Wed Mar 5 23:59:00 GMT 2008


This patch to contrib/patch_tester.sh verifies that at least one set of
tests was run.  Otherwise a bad value for check options could cause the
testsuite run to be skipped but the patch would be reported to have
caused no regressions.

Sebastian, OK for trunk?

--- patch_tester.sh.6	2008-03-05 15:29:36.000000000 -0800
+++ patch_tester.sh	2008-03-05 15:29:39.000000000 -0800
@@ -316,6 +316,12 @@ bootntest () {
     CHECK_OPTIONS=`grep "^check:" $PATCH | sed -e "s/^check://g"`
     eval make $dashj $CHECK_OPTIONS -k check &> $1/check
 
+    SUITESRUN="`grep 'Summary ===' $1/check | cut -d' ' -f 2 | sort`"
+    if [ x$SUITESRUN = x ]; then
+	report "check with `basename $1` version failed, no testsuites were run"
+	return 1
+    fi
+
     for LOG in $TESTLOGS ; do
 	if [ -f $BUILD/$LOG ]; then
 	    mv $BUILD/$LOG $1




More information about the Gcc-patches mailing list