[PATCH] fix quoting braces in RUNTESTFLAGS in install.texi
Hans-Peter Nilsson
hp@bitrange.com
Wed Mar 5 00:28:00 GMT 2008
Thanks for fixing this. I believe it's a point of confusion for
every newbie and those who already know, don't care to check it.
On Wed, 5 Mar 2008, Serge Belyshev wrote:
> Tested by inspecting "make info pdf html" output.
The test procedure at
<http://gcc.gnu.org/contribute.html#docchanges> calls for
"make dvi && make info", which would've shown...
> @smallexample
> - @dots{}"--target_board=unix/-Wextra@{-O3,-fno-strength-reduce@}@{-fomit-frame-pointer,@}"
> + @dots{}"--target_board=unix/-Wextra\@{-O3,-fno-strength-reduce\@}\@{-fomit-frame-pointer,\@}"
> @end smallexample
...that this caused "make dvi" to go:
Overfull \hbox (15.80766pt too wide) in paragraph at lines 2095--2095
[] []@smalltt
"--target_board=unix/-Wextra\{-O3,-fno-strength-reduce\}\{-fo
mit-frame-pointer,\}"[] |
so I cut off the option names. Better have working quoting than
working option names. ;) You also missed a ChangeLog. I
committed the following as obvious.
2008-03-05 Serge Belyshev <belyshev@depni.sinp.msu.ru>
* doc/install.texi (Testing): Correct quoting for the RUNTESTFLAGS
examples. Truncate option-names then causing overfull hbox.
Index: doc/install.texi
===================================================================
*** doc/install.texi (revision 132877)
--- doc/install.texi (working copy)
*************** You can run the testsuites multiple time
*** 2070,2076 ****
with a syntax similar to the brace expansion of popular shells:
@smallexample
! @dots{}"--target_board=arm-sim/@{-mhard-float,-msoft-float@}@{-O1,-O2,-O3,@}"
@end smallexample
(Note the empty option caused by the trailing comma in the final group.)
--- 2070,2076 ----
with a syntax similar to the brace expansion of popular shells:
@smallexample
! @dots{}"--target_board=arm-sim\@{-mhard-float,-msoft-float\@}\@{-O1,-O2,-O3,\@}"
@end smallexample
(Note the empty option caused by the trailing comma in the final group.)
*************** They can be combined as many times as yo
*** 2092,2098 ****
list:
@smallexample
! @dots{}"--target_board=unix/-Wextra@{-O3,-fno-strength-reduce@}@{-fomit-frame-pointer,@}"
@end smallexample
will generate four combinations, all involving @samp{-Wextra}.
--- 2092,2098 ----
list:
@smallexample
! @dots{}"--target_board=unix/-Wextra\@{-O3,-fno-strength\@}\@{-fomit-frame,\@}"
@end smallexample
will generate four combinations, all involving @samp{-Wextra}.
Index: ChangeLog
===================================================================
*** ChangeLog (revision 132877)
--- ChangeLog (working copy)
***************
*** 1,3 ****
--- 1,8 ----
brgds, H-P
More information about the Gcc-patches
mailing list