[PATCH][TUPLES] Tuplifying tree-vectorize.c

Diego Novillo dnovillo@google.com
Wed Jun 25 13:17:00 GMT 2008


On 6/24/08 12:54 PM, Doug Kwan (Ãö®¶¼w) wrote:

> When we create the phi node.  Note that the call above in just reverse the
> phis in place.  We needed to do that that in the past becase phis are inserted
> in a LIFO order.  When copying phis from one bb to another, we needed to a
> phi_reverse to preserve the order.

Ah, right.

I missed something in the review, though.  We don't really need the
function hash_gimple_stmt() as it just hashes on the pointer.  And in
fact, it introduces a bootstrap failure on 64bit hosts because you are
hashing const void * to hashval_t, which is 32 bits.  For hashing
pointers, we have to use htab_hash_pointer.  I'm committing a fix shortly.


Diego.



More information about the Gcc-patches mailing list