[lto][patch] remove local variables from types (after gimplification)

[Richard Guenther]

On Tue, Jun 24, 2008 at 3:04 PM, Rafael Espindola <espindola@google.com> wrote:
> 2008/6/24 Richard Guenther <richard.guenther@gmail.com>:
>> On Mon, Jun 23, 2008 at 4:43 PM, Rafael Espindola <espindola@google.com> wrote:
>> This works for me.  Note that if either TYPE_SIZE_UNIT or
>> TYPE_SIZE is NULL, both should be.
> Will try to add that.
>
>> Also the same handling
>> of TYPE_MAX_VALUE should apply to TYPE_MIN_VALUE - and
>> rather than setting them to zero I would suggest to set them to
>> the types natural bounds based on its precision.
> Any objections to have that semantics with NULL? Will try to add it to
> TYPE_MIN_VALUE.

While we in most places check for NULL TYPE_MIN/MAX_VALUE we
should not need to - so I'd like you to adjust it instead of NULLing it.

>>  And it looks like
>> you miss TYPE_DOMAIN of ARRAY_TYPE, which contains
>> the variable bounds of an array.
>
> The callback gets passed all types. In particular, it gets passed the
> TYPE_DOMAIN and we clean up the TYPE_MAX_VALUE of it. I did try
> setting the TYPE_DOMAIN to NULL but found many places that assume it
> is not NULL.

I think NULL TYPE_DOMAIN is/was used for incomplete arrays like
int a[] (but this may have changed to a NULL TYPE_SIZE).

Richard.