[patch] Use dg-skip-if in several ARM testcases.

Nick Clifton nickc@redhat.com
Mon Jun 16 15:30:00 GMT 2008


Hi Paul,

>>> +/* { dg-skip-if "" { *-*-* } { "-march=*" } { "-march=xscale" } } */
>>    1.  Since this is an ARM specific exception the target selector
>> should be restricted to ARMs.
> 
> We already have  /* { dg-require-effective-target arm32 } */

True, but that is tested after the dg-skip-if, so any non-ARM target 
that has a "-march=..." multilib will end up triggering this skip, 
rather than the more appropriate dg-require-effective-target.  Besides 
it never hurts to be accurate.

>>     /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* ||
>> xscale-*-* } { "-march=*" } { "-march=xscale" } } */
> 
> Support for xscale-*-* was removed a while ago (arm-*-* should be used 
> instead).

OK, but the xscale-*-* configuration is still recognized by config.gcc, 
so I thought it best to be safe and include it in the list of acceptable 
targets.

Cheers
   Nick




More information about the Gcc-patches mailing list