[trunk][patch] gimplify type sizes in a pointer type

Diego Novillo dnovillo@google.com
Fri Jun 13 16:40:00 GMT 2008


On Fri, Jun 13, 2008 at 12:06, Rafael Espindola <espindola@google.com> wrote:

> +  VEC_free(tree, heap, c->pointer_types);

Space before '('.

>  /* Look through TYPE for variable-sized objects and gimplify each such
> -   size that we find.  Add to LIST_P any statements generated.  */
> +   size that we find.  Add to LIST_P any statements generated. If
> +   GIMPLIFY_POINTERS is true, recurse into pointer types. If it is false,
> +   add the type to gimplify_ctxp->pointer_types.
> +  */

Add something like ".  These types will be gimplified when the
gimplifier leaves its current gimplification context (see
pop_gimplify_context).  */"

Closing comment should go on the same line.

> +void
> +gimplify_type_sizes (tree type, tree *list_p)

Needs comment.

> +{
> +  gimplify_type_sizes_1 (type, list_p, false);

Add comment "/* Delay gimplification of pointer types until all
the types have been seen in the current gimplification context.  */"


OK with those changes.


Diego.



More information about the Gcc-patches mailing list