[graphite] build_scops_conditions

[Sebastian Pop]

On Thu, Jun 12, 2008 at 8:22 AM, Tobias Grosser
<grosser@fim.uni-passau.de> wrote:
> I would like to commit this code. Patch attached.

Before committing, please correct formatting of comments: sentences
should begin with a capital letter, end with a point and two spaces
before new sentence or end of comment.

There are several occurrences of:

+  VEC (basic_block, heap) * dom;

that should not have the extra space after *, this should be:

+  VEC (basic_block, heap) *dom;

Also avoid useless braces, and if operators should be at the beginning
of new line when long lines are broken:

+		for (k = 0; k < n; k++)
+		  {
+		    if (label_to_block (CASE_LABEL (TREE_VEC_ELT (vec, k))) ==
+			bb_child && i != k)
+		      break;
+		  }

should be written like this:

for (k = 0; k < n; k++)
  if (label_to_block (CASE_LABEL (TREE_VEC_ELT (vec, k)))
      == bb_child && i != k)
    break;

It would be good to complete the testsuite with new testcases for the
codes that can be represented now.

Thanks for the patch,
Sebastian

--
AMD - GNU Tools