[patch i386]: Disable red zone for w64

Kai Tietz Kai.Tietz@onevision.com
Thu Jun 12 09:21:00 GMT 2008


Jan Hubicka <hubicka@ucw.cz> wrote on 11.06.2008 20:51:06:

> > On Wed, Jun 11, 2008 at 11:35:03AM +0200, Kai Tietz wrote:
> > > 2008-06-11  Kai Tietz  <kai.tietz@onevision.com>
> > > 
> > >         * config/i386/i386.c (ix86_compute_frame_layout): 
> Disable red zone for
> > >         w64 abi.
> > >         (ix86_expand_prologue): Likewise.
> > >         (ix86_force_to_memory): Likewise.
> > >         (ix86_free_from_memory): Likewise.
> > > 
> > > Tested on x86_64-pc-mingw32 without seeing any regressions.
> > > Ok for apply to trunk?
> > 
> > This is wrong, you are compile time punishing all i?86 targets.
> > IMHO you should just target_flags |= MASK_NO_RED_ZONE; in
> > override_options for the M$ ABI.
> 
> Because we need to support mixing both ABIs via attribute, we can't
> precompute this.  The extra checks should not be performance critical
> and 32bit targets will get them optimized away anyway.
> 
> So patch is OK.
> Honza
> > 
> >    Jakub
> 

Committed at revision 136693.

Thanks,
Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.



More information about the Gcc-patches mailing list