[PATCH, committed] Fix config.gcc shell lossage
Michael Meissner
michael.meissner@amd.com
Tue Jun 10 18:51:00 GMT 2008
On Tue, Jun 10, 2008 at 11:18:17AM -0700, Ian Lance Taylor wrote:
> Andreas Schwab <schwab@suse.de> writes:
>
> > Ian Lance Taylor <iant@google.com> writes:
> >
> >> Michael Meissner <michael.meissner@amd.com> writes:
> >>
> >>> - if test $enable_cld = yes; then
> >>> + if test "x$enable_cld" = xyes; then
> >>
> >> I'll just note that you don't need to use both a prefix and
> >> doublequotes. Either one alone suffices.
> >
> > Unless $enable_cld can contain whitespace, which it can.
>
> Fair enough, but you still don't need the prefix.
Yep, I thought when doing the initial patch of doing one or the other, and
decided on the belt/suspenders approach of doing both.
I'm sure I understand the case where enable_cld could have spaces in it. I
will note that other enable tests in config.gcc aren't protected with quotes.
Do people want me to fix the script to remove the quotes?
--
Michael Meissner, AMD
90 Central Street, MS 83-29, Boxborough, MA, 01719, USA
michael.meissner@amd.com
More information about the Gcc-patches
mailing list