Updated Ada Hardware Interrupt Patch

Arnaud Charlet charlet@adacore.com
Fri Jun 6 07:13:00 GMT 2008


> Updated patch attached. 

Not really. Please double check the patches you sent, thanks.

The patch you sent is almost empty:
<<
Index: s-interr-hwint.adb
Index: s-osinte-rtems.ads
Index: Makefile.in
Index: s-osinte-vxworks.adb
Index: s-osinte-vxworks.ads
>>

> Some of your comments did look like I missed
> an update after removing s-osinte-vxworks.adb

It's s-interr-vxworks.adb not s-osinte-vxworks.adb

> If you diff s-osinte-vxworks.adb
> s-osinte-hwint.adb, you will see that the changes
> are fairly mechanical and just switch to the
> adapter layer.

Well, did you do the diff before submitting this update ? I did each
time I reviewed your patch, and found issues each time.

So please confirm that you have carefully and completely reviewed the actual
patch you sent (I cannot believe you did since you sent a junk patch again)
before I can start reviewing it again.

> Please review this again.  I have been tracking the
> head for 6 months on this and would like to do
> something else. :)

Trouble is that you haven't really tracked changes in s-interr-vxworks.adb,
you've only done some svn update apparently, causing lots of extra work
on both sides because of the file renaming.

What I'd suggest is that you keep the file named s-interr-vxworks.adb
locally (and keep other changes), so that a simple svn update will
do the merges almost automatically for you, instead of waiting for me to
notice merge issues, which is not proving to be very effective.

Arno



More information about the Gcc-patches mailing list