Remove flag_really_no_inline
Jan Hubicka
jh@suse.cz
Tue Jul 29 15:18:00 GMT 2008
> On Sat, Jul 26, 2008 at 8:44 PM, Jan Hubicka <jh@suse.cz> wrote:
> >
> > Hi,
> > this patch remove another relic of RTL inliner, handling of flag_no_inline and
> > flag_really_no_inline. This was introduce to make it possible for frontend to
> > disable RTL inlining and still do tree inlining.
> > We need only one flag now. I've also removed several places we used
> > flag_really_no_inline to disable inliners; we mark all functions uninlinable
> > and this is enough to prevent them from working. With LTO we should be able
> > to combine -fno-inline units with -finline units sanely now and since the inliners
> > only look at callgraph to find inline candidates they are not going to spend
> > too much time.
> >
> > Bootstrapped/regtested i686-linux, will commit it after tuples merge.
>
> This broke Ada:
>
> ../../trunk/gcc/ada/trans.c: In function 'process_inlined_subprograms':
> ../../trunk/gcc/ada/trans.c:5706: error: 'flag_really_no_inline'
> undeclared (first use in this function)
> ../../trunk/gcc/ada/trans.c:5706: error: (Each undeclared identifier
> is reported only once
> ../../trunk/gcc/ada/trans.c:5706: error: for each function it appears in.)
> make[3]: *** [ada/trans.o] Error 1
Hi,
sorry for that. This is patch I am testing.
Honza
Index: trans.c
===================================================================
*** trans.c (revision 138235)
--- trans.c (working copy)
*************** process_inlined_subprograms (Node_Id gna
*** 5701,5709 ****
Entity_Id gnat_entity;
Node_Id gnat_body;
! /* If we can inline, generate RTL for all the inlined subprograms.
Define the entity first so we set DECL_EXTERNAL. */
! if (optimize > 0 && !flag_really_no_inline)
for (gnat_entity = First_Inlined_Subprogram (gnat_node);
Present (gnat_entity);
gnat_entity = Next_Inlined_Subprogram (gnat_entity))
--- 5701,5709 ----
Entity_Id gnat_entity;
Node_Id gnat_body;
! /* If we can inline, generate Gimple for all the inlined subprograms.
Define the entity first so we set DECL_EXTERNAL. */
! if (optimize > 0)
for (gnat_entity = First_Inlined_Subprogram (gnat_node);
Present (gnat_entity);
gnat_entity = Next_Inlined_Subprogram (gnat_entity))
More information about the Gcc-patches
mailing list