[PATCH] Fix bitfld-1.c test on i?86

Richard Guenther richard.guenther@gmail.com
Tue Jul 29 14:39:00 GMT 2008


On Tue, Jul 29, 2008 at 1:22 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> The http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125167
> merge from trunk to tuples changed check_format_types, eventhough
> that file wasn't really touched on the trunk and this change introduced
> a regression:
> FAIL: gcc.dg/format/bitfld-1.c   (test for excess errors)
> FAIL: gcc.dg/format/bitfld-1.c  -DWIDE  (test for excess errors)
> on x86_64-linux/-m32.  The following patch reverts that, I've bootstrapped
> and regtested it on x86_64-linux and also regtested with /-m32.
> Ok for trunk?

Ok (it looks obvious).

Thanks,
Richard.

> 2008-07-29  Jakub Jelinek  <jakub@redhat.com>
>
>        * c-format.c (check_format_types): Revert unwanted checkin.
>
> --- gcc/c-format.c.jj   2008-07-28 16:44:55.000000000 +0200
> +++ gcc/c-format.c      2008-07-29 10:49:55.000000000 +0200
> @@ -2262,7 +2262,7 @@ check_format_types (format_wanted_type *
>          && TREE_CODE (cur_type) == INTEGER_TYPE
>          && (!pedantic || i == 0 || (i == 1 && char_type_flag))
>          && (TYPE_UNSIGNED (wanted_type)
> -             ? wanted_type == unsigned_type_for (cur_type)
> +             ? wanted_type == c_common_unsigned_type (cur_type)
>              : wanted_type == c_common_signed_type (cur_type)))
>        continue;
>       /* Likewise, "signed char", "unsigned char" and "char" are
>
>        Jakub
>



More information about the Gcc-patches mailing list