[PATCH][ARM] Support arm-android-eabi

Mark Mitchell mark@codesourcery.com
Mon Jul 14 19:45:00 GMT 2008


Doug Kwan (關振德) wrote:

> - LINK_SPEC, STARTFILE_SPEC and ENDFILE_SPEC use default for
> non-Android targets defined in header earlier in the inclusion chain
> (bpabi.h and unknown-elf.h)

Great.  I think this is OK.  However, I would prefer the spelling 
BPABI_LINK_SPEC to LINK_BPBAI_SPEC, as I suggested earlier.  (And, 
similarly for the UNKNOWN_ELF specs.)  That's more like English ("the 
BPBABI link specification") and more like OO notation 
("BPABI::LINK_SPEC" or "BPABI.LINK_SPEC").

Please make that change, and check it in again...

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713



More information about the Gcc-patches mailing list