ABI attributes changes entry
Mark Mitchell
mark@codesourcery.com
Mon Jul 14 19:19:00 GMT 2008
Kai Tietz wrote:
>> + <li>In 64bit mode, calling convention can be specified via <code>sysv_abi</code>
>> + (used by GNU/Linux and other systems) and <code>ms_abi</code> (used by MS Windows).
>> + This allow easier implementation of environments combining both ABIs,
>> + such as wine.</li>
>> </ul>
> It's ok for me. Thank you very much.
I have some nits:
* Use "64-bit", not "64bit"
* "used by GNU/Linux and other systems" is unclear since that sounds
like "all systems" at that point. Put the ms_abi clause first, so that
it's obvious that "sysv4_abi" is "everything but Windows".
* Please spell out "Microsoft". "MS Windows" isn't an official name, as
far as I know.
* Remove the reference to wine. I think the last sentence would be
better as "You can use these attributes to write applications that use
both ABIs."
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
More information about the Gcc-patches
mailing list