[patch] PR 31754/C++ - make -fshow-column produce more accurate column numbers

[Dodji Seketeli]

Jason Merrill a écrit :
> Dodji Seketeli wrote:
>> +/// in the coming test, the column information is broken as it points to
>> +//  the end of the declaration instead of pointing to the begining of 
>> the
>> +//  'TYPE' identifier. This is due to the warning being generated by the
>> +//  declaration groking code (gcc/cp/decl.c) and not the parser. So 
>> in that
>> +//  code, the exact token location information is lost as the 
>> declaration
>> +//  groking code manipulates TREEs only.
> 
> grokdeclarator takes a cp_declarator *, and cp_declarator has a 
> location_t field.  The comment says "Currently only set for cdk_id", but 
> surely that could change.

Right. I will look into that.

> But that doesn't seem like a reason to hold up this patch; go ahead and 
> check this in and fix that in another patch.

Okay, thanks very much. I don't have the commit access to the 
repository, so I cannot commit.

Dodji.