[PATCH]: Resolve C++ keyword conflicts in gen*.c

Ian Lance Taylor iant@google.com
Thu Jul 10 03:37:00 GMT 2008


"Richard Guenther" <richard.guenther@gmail.com> writes:

> On Tue, Jul 8, 2008 at 1:10 AM, Gabriel Dos Reis
> <gdr@integrable-solutions.net> wrote:
>> On Mon, Jul 7, 2008 at 12:22 PM, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
>>> This patch eliminates some conflicts with C++ keywords in the gen*.c files.
>>>
>>> Bootstrapped on x86_64-unknown-linux-gnu, no regressions.
>>>
>>> Okay for mainline?
>>
>> The naming looks good to me -- though I do not know whether
>> people prefer template_code over code_template.
>> Richard, Ian?
>
> I don't mind either way.  But I want to raise another issue again -- the
> generator programs are C - what is the value to build them with a C++
> compiler now?  Why not disable -Wc++ for them?

This is not like the runtime library case.  The generator programs are
part of the compiler source code, and I would argue that they should
eventually be written in C++ just as the rest of the compiler should
eventually be written in C++.

Ian



More information about the Gcc-patches mailing list