get_attr_length_1 doesn't call the fallback function

[Christian BRUEL]

committed as approved,

bootrapped and regression tested for i686-pc-linux-gnu.
regression tested with sh-superh-elf and sh4-linux (on a previous 
revision, current trunk fails for sh4)

best regards

Christian

Ian Lance Taylor wrote:
> Christian BRUEL <christian.bruel@st.com> writes:
> 
> 
>>Is it normal/expected that get_attr_length_1 calls get_attr_length,
>>instead of the callback_fn when recursively called from a SEQUENCE
>>stmt?
>>
>>When it is called from get_attr_min_length, we can get the wrong
>>value, which is most of the time only an heuristic issue, but the sh4
>>is very sensitive to it (e.g to compute short conditional branch
>>distances), when INSN_ADDRESSES_SET_P () is not set.
>>
>>thanks for clarifying my view of this piece of code, or eventually
>>allow me to commit the change if it happens to be an issue.
> 
> 
> I dn't think your patch is correct.  I believe that it is possible for
> a sequence to have a new UID not recorded in insn_lengths[], but for
> the sequence to be composed of insns which UIDs which are recorded in
> insn_lengths.
> 
> So, instead of calling get_attr_length, the code should call
>     get_attr_length_1 (XVECEXP (body, 0, i), fallback_fn)
> 
> That patch is preapproved if it passes bootstrap and testing.
> 
> Thanks.
> 
> Ian
>