[PING, testsuite] Testsuite fixes for SPU

[Ulrich Weigand]

Janis Johnson wrote:
> On Wed, 2008-07-02 at 18:04 +0200, Ulrich Weigand wrote:
> > Janis Johnson wrote:
> > > On Sat, 2008-06-28 at 20:11 +0200, Ulrich Weigand wrote:
> > For this one:
> > 
> > > > http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00971.html
> > > XFAIL requires a reference to an open PR; please open a PR
> > > and reference it in the comment field of dg-skip-if.
> > 
> > I'm not sure a GCC PR is the right way to handle it; the problem
> > is that general -fPIC code does not work because the run-time
> > system does not currently process relocations.
> > 
> > This really isn't a bug in GCC; it can either be considered a
> > restriction of the platform or else a bug in the current run-time
> > environment.
> > 
> > Should these test cases then be skipped and not XFAILed under
> > those circumstances?
> 
> If it's likely to be fixed in the runtime then XFAIL it, otherwise
> skip it, with a comment in the test either way.

OK, in this case it should probably be skipped.  I've checked in the
following patch now.

Thanks,
Ulrich


	* gcc.dg/pr28243.c: Skip on SPU.
	* gcc.dg/torture/pr25947-1.c: Likewise.
	* gcc.dg/20030702-1.c: Likewise.
	* g++.old-deja/g++.other/comdat5.C: Likewise.
	* g++.old-deja/g++.other/local-alloc1.C: Likewise.
	* g++.dg/opt/vt1.C: Likewise.


Index: gcc/testsuite/gcc.dg/pr28243.c
===================================================================
*** gcc/testsuite/gcc.dg/pr28243.c	(revision 136680)
--- gcc/testsuite/gcc.dg/pr28243.c	(working copy)
***************
*** 4,9 ****
--- 4,10 ----
  /* { dg-do compile } */
  /* { dg-require-effective-target fpic } */
  /* { dg-options "-O2 -ftracer -fPIC" } */
+ /* { dg-skip-if "requires unsupported run-time relocation" { spu-*-* } { "*" } { "" } } */
  
  struct displayfuncs {
    void (*init) ();
Index: gcc/testsuite/gcc.dg/torture/pr25947-1.c
===================================================================
*** gcc/testsuite/gcc.dg/torture/pr25947-1.c	(revision 136680)
--- gcc/testsuite/gcc.dg/torture/pr25947-1.c	(working copy)
***************
*** 1,5 ****
--- 1,6 ----
  /* PR target/25947: define_split in cris.md caused unrecognized insn.  */
  /* { dg-options "-fpic" { target fpic } } */
+ /* { dg-skip-if "requires unsupported run-time relocation" { spu-*-* } { "-O0" } { "" } } */
  
  extern char *rl_line_buffer;
  extern int rl_point;
Index: gcc/testsuite/gcc.dg/20030702-1.c
===================================================================
*** gcc/testsuite/gcc.dg/20030702-1.c	(revision 136680)
--- gcc/testsuite/gcc.dg/20030702-1.c	(working copy)
***************
*** 2,7 ****
--- 2,8 ----
     correctly in combine.  */
  /* { dg-do compile { target fpic } } */
  /* { dg-options "-O2 -fpic -fprofile-arcs" } */
+ /* { dg-skip-if "requires unsupported run-time relocation" { spu-*-* } { "*" } { "" } } */
  
  void test (void)
  {
Index: gcc/testsuite/g++.old-deja/g++.other/comdat5.C
===================================================================
*** gcc/testsuite/g++.old-deja/g++.other/comdat5.C	(revision 136680)
--- gcc/testsuite/g++.old-deja/g++.other/comdat5.C	(working copy)
***************
*** 2,6 ****
--- 2,7 ----
  // { dg-do link { target fpic } }
  // { dg-additional-sources " comdat5-aux.cc" }
  // { dg-options "-O2 -fPIC" }
+ // { dg-skip-if "requires unsupported run-time relocation" { spu-*-* } { "*" } { "" } }
  
  #include "comdat4.C"
Index: gcc/testsuite/g++.old-deja/g++.other/local-alloc1.C
===================================================================
*** gcc/testsuite/g++.old-deja/g++.other/local-alloc1.C	(revision 136680)
--- gcc/testsuite/g++.old-deja/g++.other/local-alloc1.C	(working copy)
***************
*** 1,5 ****
--- 1,6 ----
  // { dg-do assemble { target fpic } }
  // { dg-options "-O0 -fpic" }
+ // { dg-skip-if "requires unsupported run-time relocation" { spu-*-* } { "*" } { "" } }
  // Origin: Jakub Jelinek <jakub@redhat.com>
  
  struct bar {
Index: gcc/testsuite/g++.dg/opt/vt1.C
===================================================================
*** gcc/testsuite/g++.dg/opt/vt1.C	(revision 136680)
--- gcc/testsuite/g++.dg/opt/vt1.C	(working copy)
***************
*** 1,6 ****
--- 1,7 ----
  // Test whether vtable for S is not put into read-only section.
  // { dg-do compile { target fpic } }
  // { dg-options "-O2 -fpic -fno-rtti" }
+ // { dg-skip-if "requires unsupported run-time relocation" { spu-*-* } { "*" } { "" } }
  // Origin: Jakub Jelinek <jakub@redhat.com>
  
  struct S


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com