Please help with 33304: global write privs / C maintainers

[Michael Meissner]

On Mon, Jun 30, 2008 at 04:36:23PM +0100, Andrew Haley wrote:
> This is pr bootstrap/33304
> 
> There a several patches needed to fix this.
> 
> These two are in c-common.c and c-tree.c:
> 
> http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00687.html
> http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00858.html
> 
> The cpp front end change <http://gcc.gnu.org/ml/gcc-patches/2008-06/msg01185.html>
> is already approved, as are the cpp test cases.
> However, this change to the c++ test suite is not yet approved:

I just re-read 6.8.3.3 of the ISO C 89/90 standard, and it is undefined.

While there might be ways of writing just one macro (for example, passing an
argument of '_') it isn't that big of a deal IMHO, and I approve of the
changes.

> (See http://gcc.gnu.org/ml/gcc-patches/2008-06/msg01346.html for context)
> 
> Index: g++.dg/ext/gnu-inline-global-reject.C
> ===================================================================
> --- g++.dg/ext/gnu-inline-global-reject.C	(revision 136895)
> +++ g++.dg/ext/gnu-inline-global-reject.C	(working copy)
> @@ -4,6 +4,7 @@
>  */
> 
>  /* { dg-do compile } */
> +/* { dg-options " -ansi -Wno-long-long" } */
> 
>  #include "gnu-inline-common.h"
> 
> Until this change to the c++ test suite and the c-common.c and c-tree.c
> fixes are approved, my (already approved) cpp fix can't go in.

This looks reasonable.

-- 
Michael Meissner
email: gnu@the-meissners.org
http://www.the-meissners.org