[PATCH] Fix 34826 (branch probability is not updated with do-loop optimization)

Revital1 Eres ERES@il.ibm.com
Thu Jan 17 22:13:00 GMT 2008


> > > Hi,
> > > the patch looks fine, however
> > > > +  /* Update the REG_BR_PROB note.  */
> > > > +  if (true_prob_val)
> > >
> > > In what cases you can end up with REG_BR_PROB being NULL here?
> >
> > I did not find such cases so far, running gcc testsuite, but I am not
> > sure it does not exist.
>
> We now should have REG_BR_PROB notes on all conditional jumps, either
> produced by the pass or guessed when CFG is being updated, but since I
> never got actually around checking the invariant and removing the
> conditionals in other places, I guess patch is OK as it is.
> (I will add this check to my TODO for stage1)

Committed to r131604.

Thanks,.
Revital



More information about the Gcc-patches mailing list