[patch] Fix for automatic parallelization
Zdenek Dvorak
rakdver@kam.mff.cuni.cz
Sat Jan 12 08:33:00 GMT 2008
Hi,
> On Jan 10, 2008 7:02 PM, Zdenek Dvorak <rakdver@kam.mff.cuni.cz> wrote:
> >
> > except for the terminology fix below, the patch is ok.
> > > +/* Return true when LOOP contains irreducible basic blocks. */
> >
> > Basic blocks are not irreducible; this should be "Return true when
> > an irreducible region is contained inside the LOOP."
> >
>
> Right, the wording of the comment is not complete, and it could also
> be: "Return true when LOOP contains basic blocks marked with the
> BB_IRREDUCIBLE_LOOP flag." Note that in the case that I corrected,
> the whole loop was in an irreducible region, so all the blocks of that
> loop were marked with the irreducible flag.
that seems somewhat suspicious, as the blocks in this subloop should not
be marked with BB_IRREDUCIBLE_LOOP flag, then. Testcase?
Zdenek
More information about the Gcc-patches
mailing list