Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c

Joseph S. Myers joseph@codesourcery.com
Tue Jan 8 18:18:00 GMT 2008


On Tue, 8 Jan 2008, Kai Tietz wrote:

>         * gcc/testsuite/gcc.dg/format/format.h: Add for mingw the gnu 
> style printf prototypes.
> 
> Do you think it is ok for apply ?

The general approach is plausible, but the patch still needs full test 
coverage for the MinGW formats before it's ready for review.  Every C90, 
C99, X/Open or GNU format feature not present on Windows should have a 
MinGW-specific test assertion added to the testsuite that the use of that 
feature is diagnosed, which every such feature present on Windows should 
have a MinGW-specific test assertion added that the feature is not 
diagnosed.  (The effect should be that every entry in the MinGW format 
datastructures is tested, and every difference from the GNU format 
datastructures.)  When you have a patch ready with such tests, please 
confirm that all the format tests pass cleanly with it applied for both 
MinGW and non-MinGW targets; then it will be ready for review.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Gcc-patches mailing list