[RFA:] more glibc fixinclude adjustments for extern inline

Bruce Korb bkorb@gnu.org
Fri Jan 4 07:50:00 GMT 2008


On Jan 2, 2008 7:37 AM, Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote:
> I see.  Reading fixincludes/README, apparently this is an effect
> of (at least) me misunderstanding "format" and c_fix_arg.  The
> *second* c_fix_arg is the actual pattern match used for the edit
> (not the "select" expression as I'd trivially expect):

Perhaps more clarification in the readme?  The second "c-fix-arg" for a "c-fix"
is the match pattern.  If omitted and if there is a "select" clause,
then that is
used instead.  See the usage of patch_args in fixfixes.c.   :)

Cheers - Bruce

Grungy detail:
TT_EGREP --> a "select" clause.
  /*
   *  IF we don't have a search text, then go find the first
   *  regular expression among the tests.
   */
  if (pz_pat == (tCC*)NULL)
    {
      tTestDesc* pTD = p_fixd->p_test_desc;
      int        ct  = p_fixd->test_ct;
      for (;;)
        {
          if (ct-- <= 0)
            {
              fprintf( stderr, zNeedsArg, p_fixd->fix_name, "search text", 1 );
              exit (EXIT_BROKEN);
            }

          if (pTD->type == TT_EGREP)
            {
              pz_pat = pTD->pz_test_text;
              break;
            }

          pTD++;
        }
    }



More information about the Gcc-patches mailing list