[RFA:] more glibc fixinclude adjustments for extern inline

Hans-Peter Nilsson hans-peter.nilsson@axis.com
Thu Jan 3 16:16:00 GMT 2008


> Date: Wed, 2 Jan 2008 16:37:30 +0100
> From: Hans-Peter Nilsson <hp@axis.com>

> > Date: Wed, 2 Jan 2008 11:28:55 +0100
> > From: "Richard Guenther" <richard.guenther@gmail.com>
> 
> > This patch seems to break coreutils build with glibc 2.6:

I can't repeat this.  While "my" wchar.h is fixinced just fine,
yours in the attachment isn't edited at all with 131302.  That's
just as expected; it doesn't match the select "(^| )extern
__inline" argument of glibc_c99_inline_5.

Is your tree pristine or what does svn diff fixincludes say?
(Perhaps I misunderstood; did you by "this patch" refer to the
commit or perhaps the suggested changes?)

> > original wchar.h and fixed wchar.h attached.
> 
> I see.

Actually, mostly I didn't.  (Reading fixfixes.c:format_fix it
appears that in absence of a second c_fix_arg, the "select"
argument is used, as I originally thought.)

brgds, H-P
PS: I wish...the fixincluded file contained the md5 of inclhack.def!



More information about the Gcc-patches mailing list