[PATCH,fortran]: Emit COMMON identifiers in proper debug scope

FX Coudert fxcoudert@gmail.com
Sat Feb 23 12:46:00 GMT 2008


> +2007-10-27  George Helffrich <ghfbsd@gly.bris.ac.uk>
> +
> +       * trans-common.c (create_common): Identifiers declared in  
> COMMON
> +       go on to the function's decl chain, not the global chain.   
> This makes
> +       the symbols appear in the proper debug scope.


I've looked more into it, and I'm now convinced that this patch is in  
principle OK: commons shouldn't be put on toplevel scope. One thing,  
though, is that in practice applying this patch makes stabs work  
better, but makes us regress on DWARF targets (where having commons  
at global scope hid the preexsiting issue): see http://gcc.gnu.org/ml/ 
gcc-patches/2007-10/msg01685.html for details.

Thus, I okay this patch conditional to the fix to dwarf2out being  
committed at the same time. So, can you make a combined patch (this  
one + the latest version of the dwarf2out patch), submit it and CC  
the dwarf or debug-info maintainer (Jim Wilson and Jason Merrill)?

Thanks,
FX

-- 
François-Xavier Coudert
http://www.homepages.ucl.ac.uk/~uccafco/



More information about the Gcc-patches mailing list