[PATCH]: testsuite fix PR objc++/34193

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Sat Feb 9 18:20:00 GMT 2008


[Sorry, the first time bounced from the mailing list.  Trying again.]

From: "Kaveh R. GHAZI" <ghazi@caip.rutgers.edu>

> This patch fixes PR objc++/34193, a failure on mainline due to an
> incorrect signature for main().  The testcase appears on 4.1 and 4.2 as
> well, but apparently the compiler is more lenient there.
>
> So I'll wonder aloud whether I should install it only on mainline.  Or
> proactively install on the branches as well, in case someone backports the
> more strict checking of main() at some future point.  Had I not had this
> question in mind, I would have already installed this as "obvious".
>
> Tested via "make check" on x86_64-unknown-linux-gnu.
>
> Okay for mainline?  Elsewhere?
>
> Thanks,
> --Kaveh
>
>
> 2008-02-08  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
>
> PR objc++/34193
> * obj-c++.dg/gnu-runtime-2.mm: Fix signature of function main().
>
> diff -rup orig/egcc-SVN20080208/gcc/testsuite/obj-c++.dg/gnu-runtime-2.mm 
> egcc-SVN20080208/gcc/testsuite/obj-c++.dg/gnu-runtime-2.mm
> --- orig/egcc-SVN20080208/gcc/testsuite/obj-c++.dg/gnu-runtime-2.mm 
> 2007-12-31 19:13:36.000000000 +0100
> +++ egcc-SVN20080208/gcc/testsuite/obj-c++.dg/gnu-runtime-2.mm 2008-02-08 
> 07:21:24.000000000 +0100
> @@ -22,7 +22,7 @@
> -(unsigned int) length  { return len; }
> @end
>
> -int main(int argc, void **args)
> +int main(int argc, const char **args)
> {
>   if (strcmp ([@"this is a string" cString], "this is a string"))
>     abort ();
> 



More information about the Gcc-patches mailing list