[PATCH][Revision4]: Don't XFAIL 21674.cc on darwin

Janis Johnson janis187@us.ibm.com
Thu Dec 18 19:00:00 GMT 2008


On Wed, 2008-12-17 at 19:43 -0500, Jack Howarth wrote:
> The attached patch corrects the syntax of a negative xfail on linux for
> libstdc++-v3/testsuite/22_locale/ctype/is/char/2.cc and implements the
> same for libstdc++-v3/testsuite/21_strings/basic_string/element_access/wchar_t/21674.cc
> and libstdc++-v3/testsuite/21_strings/basic_string/element_access/char/21674.cc on
> darwin to eliminate a the last two XPASS's in the libstdc++-v3 testsuite on
> i686-apple-darwin9. Tested on same. Okay for gcc trunk.                        

> +// { dg-do run { xfail !*-*-darwin* } }

I'm very surprised that this is accepted; it is, but unfortunately
it doesn't have any effect, according to my tests.  You need

// { dg-do run { xfail { ! { *-*-darwin* } } } }

I tried that with dummy tests on linux, one with !linux and one with
!darwin, and got the results I expected.  I'm doing to check in that
version so we don't need to continue with this.

Janis



More information about the Gcc-patches mailing list