Patch ping (i386 backend, configury)

Laurent GUERBY laurent@guerby.net
Thu Dec 18 12:49:00 GMT 2008


On Thu, 2008-12-18 at 09:29 +0100, Paolo Bonzini wrote:
> > [configury] http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00727.html
> >        P1 PR bootstrap/37739
> >        Fix powerpc*-linux 32-bit bootstrap where cc1* etc. grow
> >        too large for default 32-bit link if not -O1+ or -Wl,--relax
> 
> Just two nits:
> 
> > +	if test x${GCC} = xyes \
> > +	   && echo $CC | ${CC} -E -dD -xc - \
> > +	      | grep '__SIZEOF_LONG__[ 	][ 	]*4' > /dev/null; then
> 
> ac_cv_sizeof_long should be already set here, so instead of forking $CC
> and grep you can do this
> 
>   if test "${GCC}:${ac_cv_sizeof_long}" = yes:4; then
> 
> > +ifeq ($(filter-out -O0,$(filter -O%,$(CFLAGS))),)
> 
> More easily understood and more precise if written as:
> 
>   ifeq ($(lastword $(filter -O%,$(CFLAGS))),-O0)
> 
> I wouldn't actually oppose always compiling stage1 at -O1; the topic has
> been raised many times.  Maybe for 4.5.

This would also help arm-linux-gnueabi:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38523

Laurent



More information about the Gcc-patches mailing list