[PATCH] s390: performance fix for tc pipeline recycle on z10

Andreas Krebbel krebbel@linux.vnet.ibm.com
Tue Dec 16 13:18:00 GMT 2008


Hi Wolfgang,

> Many thanks. Concerning the brackets: I consider them as "defensive
> programming style". A project I was with some years ago had plenty of
> problems related to ill-formed expressions mixing comparisons, bitwise 
> and logical
> operations in a way that finally caused unexpected effects. Since then,
> I prefer having one pair of brackets too much, in particular since they
> get removed very early in the translation process.

Sure, nothing against brackets in general :)

But please avoid trivially superfluous brackets as in:
+          if ((prev_insn != NULL_RTX) && INSN_P (prev_insn)

Bye,

-Andreas-



More information about the Gcc-patches mailing list