Fix crash in rtl verifier

Andreas Schwab schwab@suse.de
Fri Dec 12 18:52:00 GMT 2008


Eric Botcazou <ebotcazou@adacore.com> writes:

>> While hunting down another bug I experienced a crash in
>> rtl_verify_flow_info_1: a BARRIER insn doesn't have a bb pointer.
>> Although the crash does not happen any more with the specific test case
>> I used, this still looks obvious to me, so I checked it in.
>
> That looks questionable to me.  While it's true that a BARRIER insn doesn't 
> have a bb pointer, the opposite holds as well: a BARRIER should not appear in 
> a basic block.  So your change might end up hiding the real problem.

Perhaps it should be turned into an assert then.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Gcc-patches mailing list